Skip to content

Update MinimumCostPath.js #548

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

Update MinimumCostPath.js #548

wants to merge 3 commits into from

Conversation

DhruvGheewala
Copy link
Contributor

@DhruvGheewala DhruvGheewala commented Dec 9, 2020 •
edited
Loading

Welcome to JavaScript community

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new JavaScript files are placed inside an existing directory.
  • All filenames should use the UpperCamelCase (PascalCase) style. There should be no spaces in filenames.
    Example:UserProfile.js is allowed but userprofile.js,Userprofile.js,user-Profile.js,userProfile.js are not
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@pomkarnath98 pomkarnath98 added the bug Something isn't working label Dec 19, 2020
@pomkarnath98
Copy link
Member

Thanks for your contribution. But your code isn't giving correct output. Please re-check it

@DhruvGheewala
Copy link
Contributor Author

Hey @pomkarnath98, can you please that test case on which code fails??

@pomkarnath98
Copy link
Member

@DhruvGheewala what should be the output for your testcase and what is coming here?

@DhruvGheewala
Copy link
Contributor Author

@DhruvGheewala what should be the output for your testcase and what is coming here?

Sorry, I don't understand what are you trying to say...

@pomkarnath98
Copy link
Member

IMG_20201220_181214
Can you please tell what should be the output for this and what is your code giving?

@DhruvGheewala
Copy link
Contributor Author

@pomkarnath98 , I have resolved and updated the file. You can see it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DhruvGheewala @pomkarnath98